Skip to content

[eng/common] Update-DocsMsMetadata.ps1 can fail the build on invalid packages#6530

Merged
danieljurek merged 3 commits intomainfrom
djurek/common-fail-daily-build-on-invalid-docs
Jul 19, 2023
Merged

[eng/common] Update-DocsMsMetadata.ps1 can fail the build on invalid packages#6530
danieljurek merged 3 commits intomainfrom
djurek/common-fail-daily-build-on-invalid-docs

Conversation

@danieljurek
Copy link
Member

@danieljurek danieljurek commented Jul 18, 2023 •
edited
Loading

This PR adds the ability to fail nightly docs builds if validation fails. This capability is not active in this PR as these need to be individually wired up in docindex.yml

Example builds:

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 18, 2023

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Jul 18, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@danieljurek danieljurek self-assigned this Jul 18, 2023
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 18, 2023

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@danieljurek
Copy link
Member Author

danieljurek commented Jul 18, 2023

Partial: #6463

@danieljurek danieljurek mentioned this pull request Jul 18, 2023
Closed
weshaggard
weshaggard reviewed Jul 18, 2023
View reviewed changes
weshaggard
weshaggard reviewed Jul 18, 2023
View reviewed changes
benbp
benbp reviewed Jul 18, 2023
View reviewed changes
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 18, 2023

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jul 19, 2023
@azure-sdk @danieljurek
Sync eng/common directory with azure-sdk-tools for PR 6530 (#26530)
c4c8d9a 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#6530 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Daniel Jurek <djurek@microsoft.com>
@danieljurek danieljurek merged commit b364347 into main Jul 19, 2023
@danieljurek danieljurek deleted the djurek/common-fail-daily-build-on-invalid-docs branch July 19, 2023 04:34
dgetu pushed a commit to Azure/azure-sdk-for-js that referenced this pull request Sep 6, 2023
@azure-sdk @danieljurek @dgetu
Sync eng/common directory with azure-sdk-tools for PR 6530 (#26530)
194466d 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#6530 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benbp benbp benbp approved these changes

@weshaggard weshaggard weshaggard approved these changes

@konrad-jamrozik konrad-jamrozik Awaiting requested review from konrad-jamrozik

Assignees

@danieljurek danieljurek

Labels

None yet

Projects

Azure SDK EngSys 📆🎇
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danieljurek @azure-sdk @benbp @weshaggard